Repository navigation
Guard Lua provider admission and verify rooted coroutine dispatch - #90
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Reject a host-provided Lua state with a negative stack top before stamp verification, and reject stamp verification that changes that top. Both paths release operation admission through the existing exception cleanup; they do not reset the stack or retry the provider.
Add managed boundary tests for negative or changed stack-top observations, with invariant failure diagnostics. Add real Lua 5.3 fixtures that preserve existing stack values and exercise rooted worker/main coroutine dispatch, repeated success and exception paths, and queued-stop cleanup.
Scope and ownership
SDK Lua admission and Hosting regression fixtures only. No Client workflow, native bridge, dependency, or public API changes. The guards contain invalid provider state; the original released-bundle dispatcher failure remains unexplained and is not claimed fixed.
Validation
The earlier live dispatcher failure did not reproduce during the diagnostic replay. Plugin reload remains blocked by the private Settings bridge's empty plugin checklist. Neither observation establishes full SDK host qualification.
Compatibility and release impact
No public API change. Invalid provider states fail earlier with an InvalidOperationException; existing admission cleanup is preserved. Valid caller-owned stack values remain intact. CHANGELOG.md records the behavior under Unreleased. Installed and released binaries are unchanged.
Checklist